#1100 mod_pubsub: pubsub_error_reply function doesn't handle arbitrary errors

Reporter Zash
Owner Zash
Created
Updated
Stars ★ (1)
Tags
  • Priority-Medium
  • Type-Defect
  • Milestone-0.11
  • Status-Fixed
  1. Zash on

    What steps will reproduce the problem? Storage errors with persistent pubsub enabled. Possibly other paths as well. What is the expected output? Error reply to the current stanza. What do you see instead? error Traceback[c2s]: plugins/mod_pubsub/pubsub.lib.lua:31: bad argument #1 to 't_unpack' (table expected, got nil) stack traceback: [C]: in function 't_unpack' plugins/mod_pubsub/pubsub.lib.lua:31: in function 'pubsub_error_reply' plugins/mod_pubsub/pubsub.lib.lua:308: in function 'handler' plugins/mod_pubsub/pubsub.lib.lua:118: in function <plugins/mod_pubsub/pubsub.lib.lua:105> (...tail calls...) ./util/events.lua:79: in function <./util/events.lua:75> (...tail calls...) plugins/mod_iq.lua:38: in function '?' ./util/events.lua:79: in function <./util/events.lua:75> (...tail calls...) ./core/stanza_router.lua:190: in function 'core_post_stanza' ./core/stanza_router.lua:137: in function 'core_process_stanza' plugins/mod_c2s.lua:263: in function 'func' ./util/async.lua:92: in function <./util/async.lua:90> What version of the product are you using? On what operating system? trunk c4222e36333c

  2. Zash on

    I believe this was fixed by https://hg.prosody.im/trunk/rev/82f92af4b0f3

    Changes
    • owner Zash
    • tags Milestone-0.11 Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.