#1183 [mod_http] Missing slash between path of "http_external_url" and http module path

Reporter Thomas Lange
Owner Zash
Created
Updated
Stars ★ (1)
Tags
  • Milestone-0.10
  • Priority-Medium
  • Status-Fixed
  • Type-Defect
  1. Thomas Lange on

    Hi. I found a little bug in mod_http (shipped with Prosody 0.10.2). To reproduce the bug, just define a custom "http_external_url" somewhere in the configuration file with a value like "https://example.org/xmpp-service/" and restart Prosody afterwards. Now take a look into the prosody.log logfile. Expected result: […] http_upload info URL: <https://example.org/xmpp-service/upload>; Storage path: […] Actual result: […] http_upload info URL: <https://example.org/xmpp-serviceupload>; Storage path: […] Best regards, - Thomas

  2. Zash on

    Thanks for the report. I can reproduce.

    Changes
    • tags Status-Accepted
  3. Zash on

    Reproducible all the way to when this API was added. This has never worked.

  4. Zash on

    To be clear, this bug only happens if http_external_url is set to an URL that includes a path other than '/'.

    Changes
    • title [mod_http] Missing slash between the value of "http_external_url" and "upload" [mod_http] Missing slash between path of "http_external_url" and http module path
    • tags Status-Started
    • owner Zash
  5. Zash on

    Fixed in https://hg.prosody.im/0.10/rev/09e7b0048ebe

    Changes
    • tags Status-Fixed
  6. Zash on

    Changes
    • tags Milestone-0.10

New comment

Not published. Used for spam prevention and optional update notifications.