#1213 [patch] Add OMEMO support to mod_conversejs

Reporter bert
Owner Zash
Created
Updated
Stars ★ (1)
Tags
  • Status-WontFix
  • Type-Enhancement
  • Priority-Medium
  1. bert on

    Description of feature: With Converse.js 4.0.0 it's possible to use OMEMO encryption. As explained by the author jcbrand (https://github.com/conversejs/converse.js/issues/497#issuecomment-417962030) , for OMEMO to work, libsignal has to be loaded and available. To enable libsignal with mod_conversejs, the following line can be added to https://hg.prosody.im/prosody-modules/file/908b2bc05d26/mod_conversejs/mod_conversejs.lua between line 18 and 19: ``` <script src="https://cdn.rawgit.com/signalapp/libsignal-protocol-javascript/f5a838f1/dist/libsignal-protocol.js" ></script> ``` I used the 3rd party service rawgit to serve the javascript from Signal's repo. (see: https://github.com/rgrove/rawgit/blob/master/FAQ.md and https://github.com/signalapp/libsignal-protocol-javascript/blob/master/dist/libsignal-protocol.js) Motivation: (Why?) To enable OMEMO support for people who use mod_conversejs (sorry for doing this so awkwardly via issue report, but I don't know how hg works :) )

  2. Bert on

    Alternatively, we could also use jsdelivr.net instead of rawgit. (https://cdn.jsdelivr.net/gh/signalapp/libsignal-protocol-javascript/dist/libsignal-protocol.js)

  3. Zash on

    I don't think this is a good idea for several reasons. Firstly, loading this kind of crypto related code from some CDN I never heard of seems like a very bad idea. It may give a false sense of security. Secondly, libsignal is licensed under GPL. The same reason it's not included in the Converse.js bundle may be a valid reason to not include it here. In short, if you want OMEMO, I recommend you do this change locally.

    Changes
    • tags Status-WontFix
    • owner Zash
  4. Bert on

    Fair enough.

  5. MattJ on

    I pushed an update to mod_conversejs that allows you to add custom tags to the generated page: https://modules.prosody.im/mod_conversejs.html#additional-tags Hopefully this should solve this and other use-cases, and leave license issues up to site administrators.

New comment

Not published. Used for spam prevention and optional update notifications.