#1374 http uploaded files get served with no Content-Type

Reporter pep.
Owner Zash
Created
Updated
Stars ★ (1)
Tags
  • Status-Fixed
  • Priority-Medium
  • Type-Defect
  • Component-Community
  1. pep. on

    What steps will reproduce the problem? 1. setup mod_http_upload from prosody-modules 2. upload a file with a client What is the expected output? Content-Type should be present in the headers when GETing the file. What do you see instead? curl --verbose https://the/file doesn't show/see that header. What version of the product are you using? On what operating system? prosody: trunk / 737483a4b2e6 prosody-modules: b33b2fbdc713 Please provide any additional information below. Reverting prosody-module's b059a3fb2a58 (pointed out by Zash as a test) seems to fix the issue.

  2. Zash on

    Thanks mod_http_upload previously relied on mod_http_files to serve the uploaded files, which also included handling of mime types. The file serving part of mod_http_files have been split up in trunk to simplify reuse, but the mime handling parts are still in mod_http_files and mod_http_upload no longer gets that handled.

    Changes
    • tags Status-Accepted Component-Community
  3. Zash on

    Fixed in https://hg.prosody.im/prosody-modules/rev/a578b4977bb0 MIME type handling needs some cleanup at some point in the future.

    Changes
    • tags Status-Fixed
    • owner Zash

New comment

Not published. Used for spam prevention and optional update notifications.