#1403 mod_admin_telnet’s s2s:show() doesn’t list all bidi s2s as bidi

Reporter Link Mauve
Owner Zash
Created
Updated
Stars ★ (1)
Tags
  • Priority-Medium
  • Status-Fixed
  • Milestone-0.12
  • Type-Defect
  1. Link Mauve on

    What steps will reproduce the problem? 1. Enable mod_bidi. 2. s2s with a server doing bidi. 3. Connect to mod_admin_telnet. 4. s2s:show() What is the expected output? | <- jabber.fr [s2sinfbc45f8] (authenticated) (encrypted) (IPv6) (bidi) What do you see instead? | -> yax.im [s2soutb001df0] (authenticated) (encrypted) (IPv6) What version of the product are you using? On what operating system? Prosody trunk r9855 changeset 115b5e32d960, on ArchLinuxARM. Please provide any additional information below. I have checked my debug logs, and both are successfully negotiated as bidi. All working entries (i.e. displaying “(bidi)”) are shown as s2sin, the issue may be specific to those established as s2sout.

  2. Zash on

    Thanks for the report. is_bidi is a flag set only on s2sin, signaling that it is ok to also send outgoing stanzas s2sout sessions can't receive stanzas due to core routing code rejecting that, so these have a bidi_session field containing a dummy s2sin to use as origin for incoming stanzas.

    Changes
    • owner Zash
    • tags Milestone-0.12 Status-Started
  3. Zash on

    Fixed in https://hg.prosody.im/trunk/rev/5c8526790a18

    Changes
    • tags Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.