Somebody added urn:xmpp:carbons:rules:0 as a "feature tag" into XEP-0280, version 0.13.0. Please:
- review what deviations mod_carbons contains from https://xmpp.org/extensions/xep-0280.html#recommended-rules
- implement those deviatons
- add the feature flag.
Thank you very much :)
Zash
on
Currently it deviates on "contains payload elements typically used in IM" and handling of groupchat messages.
Changes
owner Zash
tags Status-Started Milestone-0.12
Zash
on
It's unclear to me what messages would have IM payloads but are not be type = chat|normal|groupchat. We don't want to carbon type=groupchat that happens to have chatstates for example.
Messages with receipts are currently implicitly covered if they get archived by mod_mam, so an explicit check could be added there. But here too it would be weird to cover type=groupchat.
Somebody added urn:xmpp:carbons:rules:0 as a "feature tag" into XEP-0280, version 0.13.0. Please: - review what deviations mod_carbons contains from https://xmpp.org/extensions/xep-0280.html#recommended-rules - implement those deviatons - add the feature flag. Thank you very much :)
Currently it deviates on "contains payload elements typically used in IM" and handling of groupchat messages.
ChangesIt's unclear to me what messages would have IM payloads but are not be type = chat|normal|groupchat. We don't want to carbon type=groupchat that happens to have chatstates for example. Messages with receipts are currently implicitly covered if they get archived by mod_mam, so an explicit check could be added there. But here too it would be weird to cover type=groupchat.
Fixed by Zash in https://hg.prosody.im/trunk/rev/8ccb22c0fa56 There remains some ambiguity, but we feel we've matched the XEP as closely as we reasonably can.
Changes