#1512 muc roomconfig allowmemberinvites not implemented correctly
Reporter
Laurent
Owner
Nobody
Created
Updated
Stars
★ (1)
Tags
Priority-Medium
Type-Defect
Status-Invalid
Laurent
on
What steps will reproduce the problem?
1. create room (muc) with default value
2. client recover config form (as per XEP-0045) : value muc#roomconfig_allowmemberinvites is absent from config returned to client
What version of the product are you using? On what operating system?
=> Debian 10.3 Prosody 0.11.4
Please provide any additional information below.
=> is there a glitch in plugins\muc\members_only.lib.lua lines 66, 83 and 96 where we can see :
- name = "{http://prosody.im/protocol/muc}roomconfig_allowmemberinvites";
- module:hook("muc-config-submitted/{http://prosody.im/protocol/muc}roomconfig_allowmemberinvites", function(event)
Shouldn't it be (as per other config variables)?
- name = "muc#roomconfig_allowmemberinvites";
- module:hook("muc-config-submitted/muc#roomconfig_allowmemberinvites", function(event)
Thanks in advance, best regards,
Laurent
Zash
on
Thanks for the report.
I believe you are confusing this setting with muc#roomconfig_allowinvites,
which is about allowing anyone in the room to invite others, while this
setting is about *members* inviting others. This is a non-standard and
Prosody-specific setting which is why it is namespaced with Clark notation
as per XEP-0068.
Changes
tags Status-Invalid
Laurent
on
Indeed, sorry to have mixed them up.
But i'm still confused as my issue is really not to have any "muc#roomconfig_allowinvites" returned by prosody at all. Browsing into the code of prosody gives no result for "roomconfig_allowinvites". Is this variable not implemented in Prosody?
What steps will reproduce the problem? 1. create room (muc) with default value 2. client recover config form (as per XEP-0045) : value muc#roomconfig_allowmemberinvites is absent from config returned to client What version of the product are you using? On what operating system? => Debian 10.3 Prosody 0.11.4 Please provide any additional information below. => is there a glitch in plugins\muc\members_only.lib.lua lines 66, 83 and 96 where we can see : - name = "{http://prosody.im/protocol/muc}roomconfig_allowmemberinvites"; - module:hook("muc-config-submitted/{http://prosody.im/protocol/muc}roomconfig_allowmemberinvites", function(event) Shouldn't it be (as per other config variables)? - name = "muc#roomconfig_allowmemberinvites"; - module:hook("muc-config-submitted/muc#roomconfig_allowmemberinvites", function(event) Thanks in advance, best regards, Laurent
Thanks for the report. I believe you are confusing this setting with muc#roomconfig_allowinvites, which is about allowing anyone in the room to invite others, while this setting is about *members* inviting others. This is a non-standard and Prosody-specific setting which is why it is namespaced with Clark notation as per XEP-0068.
ChangesIndeed, sorry to have mixed them up. But i'm still confused as my issue is really not to have any "muc#roomconfig_allowinvites" returned by prosody at all. Browsing into the code of prosody gives no result for "roomconfig_allowinvites". Is this variable not implemented in Prosody?