#33 Return error replies for undeliverable s2s stanzas
Reporter
MattJ
Owner
MattJ
Created
Updated
Stars
★ (1)
Tags
Milestone-0.2
Status-Fixed
Type-Defect
Priority-High
MattJ
on
Currently outgoing s2s stanzas are lost in the void if an s2s connection
fails for any reason.
Most of the pieces for this are done now.
MattJ
on
The places I see we need to do this:
attempt_connection() in s2smanager (when it gives up)
When dialback fails
When we get a stream error, with stanzas in the queue
As I said, I'm mostly concerned with cheaply storing whatever metadata we need to
keep for bouncing back the stanzas.
Changes
owner Waqas
Waqas
on
The send queue is now bounced on failed connect, but not on failed dialback. You had
a FIXME for that? Over to you Matt. All that's required is a call to destroy_session
(which should be called anyway, even if there is no queue).
Currently outgoing s2s stanzas are lost in the void if an s2s connection fails for any reason. Most of the pieces for this are done now.
The places I see we need to do this: attempt_connection() in s2smanager (when it gives up) When dialback fails When we get a stream error, with stanzas in the queue As I said, I'm mostly concerned with cheaply storing whatever metadata we need to keep for bouncing back the stanzas.
ChangesThe send queue is now bounced on failed connect, but not on failed dialback. You had a FIXME for that? Over to you Matt. All that's required is a call to destroy_session (which should be called anyway, even if there is no queue).
Changes