*Description of feature:*
Please provide the possibility to mimic the behaviour of ejabberd and provide an option how many history messages a server should send, when joining a MUC.
With client which don't implement XEP-0045 properly (f.e. Pidgin/libpurple) this is really valuable.
dittler@informatik.hu-berlin.de
on
I implemented it myself.
With "default_history_messages = 20" everything will stay the same, otherwise it will send default_history_messages to clients, which don't request a specific number.
Can we push this into the module?
Hi, thanks for the patches! Both look good.
Do you need the functionality of the second one? (per-room configuration). If not, I lean towards merging the simpler smaller one, I don't currently see a case where you would strongly want this to be per-room.
Changes
tags Type-Enhancement Milestone-0.9
dittler@informatik.hu-berlin.de
on
Hey Matthew,
I have no specific need for patch #2. It was a suggestion by Zash.
#1 is fine with me.
dittler@informatik.hu-berlin.de
on
Why didn't it make this patch into 0.9.5 or 0.9.6? I'm waiting desperately.
dittler
on
I use the moving of the issue tracker to point out, that there are still two unmerged patches in this issue.
C. Schanck
on
Really, really waiting on this. Any news?
MattJ
on
Sorry, for some reason I thought this was in already. We're working on a new release shortly, will take a look at it.
Mykhailo Danylenko
on
Inclusion into the upstream will be appreciated - I need this feature too. Thanks in advance!
Mykhailo Danylenko
on
Hey!
0.9.9 and 0.9.10 had come out, but this is still not in the upstream! Bumping.
akosiaris
on
Bumping as well. Please include this patch. I had to locally patch my prosody install everytime I upgrade
Zash
on
Changes
tags Patch
dittler
on
Bumping this another time. Why not include it in 0.10.*?
MattJ
on
Hey, you're right... sorry about the poor handling of this issue. Working through our backlog of patches is one of my top priorities at the moment.
I will be looking at merging 2 patches today for MUC in 0.10, and this is one of them.
Changes
tagsMilestone-0.9 Milestone-0.10
MattJ
on
The patch is merged, and will be in the next 0.10 nightly build and the 0.10.2 release when we make it.
Thanks for the contribution, and once again apologies about the delay in merging it.
Changes
tags Status-Fixed
MattJ
on
Looking at trunk (where the MUC code has been significantly rewritten), it has a different behaviour.
The history length of the room is configurable (per room). By default it always sends all the history. Do you still require the number of messages sent to be configurable separately from the number of messages actually available in the history?
MattJ
on
Ignore my last comment, I managed to port the patch so the behaviour should be identical in 0.10 and trunk now.
Jonas
on
Has this patch been merged and released in one of the subsequent 0.10 releases already? I wasn't able to find the corresponding commit.
MattJ
on
Sorry, I meant to re-open this issue. Numerous problems were reported after merging the patch, and due it being a stable branch and a security release that everyone would need to upgrade to, we reverted the base commit and the fixes on top of it.
https://hg.prosody.im/0.10/rev/463505cc75d5
If someone can provide an updated patch for 0.10 that is well-tested, I'm still not opposed to including it. As it is, I don't have time to work out these issues myself as my focus is on getting the next branch ready for release.
Changes
tags Status-Accepted
dittler
on
With MAM being the standard now, this patch is not important to me anymore. If anyone wants, please work on it, but otherwise let's forget about it.
Jonas
on
I'm also ok with dropping the patch alltogether if @dittler doesn't need it anymore.
Zash
on
It's been quiet here a while and 0.10 is EOL, so ... drop or nah?
Changes
tagsMilestone-0.10 Status-NeedInfo
Zash
on
The history mechanism is largely replaced by MAM these days, so I'll close this for lack of activity.
*Description of feature:* Please provide the possibility to mimic the behaviour of ejabberd and provide an option how many history messages a server should send, when joining a MUC. With client which don't implement XEP-0045 properly (f.e. Pidgin/libpurple) this is really valuable.
I implemented it myself. With "default_history_messages = 20" everything will stay the same, otherwise it will send default_history_messages to clients, which don't request a specific number. Can we push this into the module?
Attachmentsi made a better patch that is configurable per room
AttachmentsHi, thanks for the patches! Both look good. Do you need the functionality of the second one? (per-room configuration). If not, I lean towards merging the simpler smaller one, I don't currently see a case where you would strongly want this to be per-room.
ChangesHey Matthew, I have no specific need for patch #2. It was a suggestion by Zash. #1 is fine with me.
Why didn't it make this patch into 0.9.5 or 0.9.6? I'm waiting desperately.
I use the moving of the issue tracker to point out, that there are still two unmerged patches in this issue.
Really, really waiting on this. Any news?
Sorry, for some reason I thought this was in already. We're working on a new release shortly, will take a look at it.
Inclusion into the upstream will be appreciated - I need this feature too. Thanks in advance!
Hey! 0.9.9 and 0.9.10 had come out, but this is still not in the upstream! Bumping.
Bumping as well. Please include this patch. I had to locally patch my prosody install everytime I upgrade
Bumping this another time. Why not include it in 0.10.*?
Hey, you're right... sorry about the poor handling of this issue. Working through our backlog of patches is one of my top priorities at the moment. I will be looking at merging 2 patches today for MUC in 0.10, and this is one of them.
ChangesMilestone-0.9Milestone-0.10The patch is merged, and will be in the next 0.10 nightly build and the 0.10.2 release when we make it. Thanks for the contribution, and once again apologies about the delay in merging it.
ChangesLooking at trunk (where the MUC code has been significantly rewritten), it has a different behaviour. The history length of the room is configurable (per room). By default it always sends all the history. Do you still require the number of messages sent to be configurable separately from the number of messages actually available in the history?
Ignore my last comment, I managed to port the patch so the behaviour should be identical in 0.10 and trunk now.
Has this patch been merged and released in one of the subsequent 0.10 releases already? I wasn't able to find the corresponding commit.
Sorry, I meant to re-open this issue. Numerous problems were reported after merging the patch, and due it being a stable branch and a security release that everyone would need to upgrade to, we reverted the base commit and the fixes on top of it. https://hg.prosody.im/0.10/rev/463505cc75d5 If someone can provide an updated patch for 0.10 that is well-tested, I'm still not opposed to including it. As it is, I don't have time to work out these issues myself as my focus is on getting the next branch ready for release.
ChangesWith MAM being the standard now, this patch is not important to me anymore. If anyone wants, please work on it, but otherwise let's forget about it.
I'm also ok with dropping the patch alltogether if @dittler doesn't need it anymore.
It's been quiet here a while and 0.10 is EOL, so ... drop or nah?
ChangesMilestone-0.10Status-NeedInfoThe history mechanism is largely replaced by MAM these days, so I'll close this for lack of activity.
Changes