#667 MUC message with subject and body SHALL NOT be interpreted as a subject change

Reporter Zash
Owner Zash
Created
Updated
Stars (0)
Tags
  • Milestone-0.12
  • Priority-Medium
  • Status-Fixed
  • Difficulty-Easy
  • Compliance
  • Type-Defect
  1. Zash on

    Please provide a snippet of the part of the specification which we violate if possible: The subject is changed by sending a message of type "groupchat" to the <room@service>, where the <message/> MUST contain a <subject/> element that specifies the new subject but MUST NOT contain a <body/> element (or a <thread/> element). In accordance with the core definition of XMPP, other child elements are allowed (although the entity that receives them might ignore them). Reproduce by sending: <message type='groupchat'><subject>foo</subject><body>bar</body></message> to a room (where you are allowed to change the subject), you receive <message type='groupchat' from='room@muc.example/a'><subject>ho</subject></message> indicating that the subject was changed. Can be confirmed by inspecting the internal data structure. Please provide a link to the specification: http://xmpp.org/extensions/xep-0045.html#subject-mod Tested with versions: - 0.9.10 - 0.10 4b4cf0167391 - trunk f4d51870d212 The current behavior may be justified if there are clients that would interpret messages with both subject and body as a legitimate subject change. Another option would be to reject such messages.

  2. MattJ on

    Moving this to the next milestone. Let's make the change and see what breaks.

    Changes
    • tags Milestone-0.12
  3. Zash on

    Done in https://hg.prosody.im/trunk/rev/b2d6b79c9513 Needs some tests.

    Changes
    • owner Zash
    • tags Difficulty-Easy Status-Fixed
  4. Zash on

    A test case added in https://hg.prosody.im/trunk/rev/e98b901446d0

  5. Zash on

    Breakage discovered so far: - https://dev.gajim.org/gajim/gajim/issues/9491 - https://github.com/conversejs/converse.js/issues/1369 Correct handling: - Swift

  6. Zash on

    Psi v0.15 (in Debian 9) also treats subject+body as topic change

  7. lovetox on

    Is fixed in Gajim now and will be in Gajim 1.1.1 https://dev.gajim.org/gajim/gajim/commit/b8863e82be783e43c4d8bcc29d5243e61b8f3d51

New comment

Not published. Used for spam prevention and optional update notifications.