#689 MUST keep full subscription request stanza

Reporter Zash
Owner MattJ
Created
Updated
Stars ★★ (2)
Tags
  • Priority-High
  • Patch
  • Type-Defect
  • Status-Fixed
  • Milestone-0.12
  • Compliance
  1. Zash on

    Please provide a snippet of the part of the specification which we violate if possible: <blockquote>[...] if the contact has no available resources when the subscription request is received by the contact's server, then the contact's server MUST keep a record of the complete presence stanza comprising the subscription request, including any extended content contained therein (see Section 8.4 of [XMPP‑CORE]), and then deliver the request when the contact next has an available resource. </blockquote> Prosody keeps only the JID here. Please provide a link to the specification: http://xmpp.org/rfcs/rfc6121.html#sub-request-inbound

  2. Ge0rG on

    So this is also a blocker for PARS (https://xmpp.org/extensions/xep-0379.html) if the other party is currently offline?

  3. MattJ on

    Possible patch? https://matthewwild.co.uk/uploads/stdin-uNHnqoPw.diff

    Changes
    • tags Status-Accepted Milestone-0.12
  4. MattJ on

    Changes
    • tags Patch
  5. MattJ on

    Changes
    • tags Priority-High
  6. Zash on

    Possible fix for possible patch: https://prosody.im/pastebin/fa78b1fe-1978-4b64-8d8d-ed48ef9fafc0

  7. Zash on

    Final fix, looks to be working https://prosody.im/pastebin/be7cc8ef-d22a-43ba-884f-49c0c7123e51

  8. Zash on

    Test added: https://hg.prosody.im/trunk/rev/e41d8b12cb47

    Changes
    • owner MattJ
    • tags Status-Started
  9. Zash on

    Fixed in https://hg.prosody.im/trunk/rev/e50559a42dfe

    Changes
    • tags Status-Fixed
  10. ge0rg on

    Are there any chances to get this backported into 0.11? :)

New comment

Not published. Used for spam prevention and optional update notifications.