#1218 Binary XOR will throw an exception with mismatched keys.
Reporter
Marco Cirillo
Owner
Nobody
Created
Updated
Stars
★ (1)
Tags
Type-Defect
Priority-Medium
Status-Fixed
Milestone-0.12
Marco Cirillo
on
What steps will reproduce the problem?
1. A choppy client sends client signature and proof of different length during SCRAM
What is the expected output?
A malformed-request error
What do you see instead?
Nothing as that causes an exception in binaryXOR()
What version of the product are you using? On what operating system?
Applicable to all versions supporting SCRAM I suppose upto Trunk.
What steps will reproduce the problem? 1. A choppy client sends client signature and proof of different length during SCRAM What is the expected output? A malformed-request error What do you see instead? Nothing as that causes an exception in binaryXOR() What version of the product are you using? On what operating system? Applicable to all versions supporting SCRAM I suppose upto Trunk.
https://hg.prosody.im/trunk/rev/ddc17e9c66e4 should have made that impossible
Changes