#1535 Let Prosody support MUC presence probes

Reporter JC Brand
Owner Zash
Created
Updated
Stars ★ (1)
Tags
  • Compliance
  • Milestone-0.12
  • Priority-Medium
  • Type-Defect
  • Patch
  • Status-Fixed
  1. JC Brand on

    Please provide a snippet of the part of the specification which we violate if possible: XEP-0045 section 17.3 point 4. Please provide a link to the specification: https://xmpp.org/extensions/xep-0045.html#bizrules-presence I've created a patch file here: https://gist.github.com/jcbrand/3e193146df2fc37a96fdead0c17e9f3f

  2. Zash on

    Thanks for the patch, but unfortunately it will not apply cleanly, possibly because the indentation has been replaced by spaces.

    Changes
    • tags Patch
  3. Zash on

    Hm, determining if you are still online can be done with a XEP-0199 ping, and re-synchronizing presence can be done by sending another join stanza. Is this really needed?

  4. JC Brand on

    > Is this really needed? For my particular use-case, yes, and my use-case is very similar to the example given in XEP-0045. In my use-case the MUC presence stanzas aren't being sent (except for mods), but when I receive a message I need XEP-0317 hats information for the message author, so I want to send out a probe for that. BTW, the above patch is rubbish and doesn't work. Here's a better one (should now be with tabs, it's a Github gist setting): https://gist.github.com/jcbrand/915989ae17bb7fdef2ff9119893a35fa

  5. JC Brand on

    Updated patch which now contains a scansion test and some resulting bug fixes: https://gist.github.com/jcbrand/e51be998d999b0a97b79eebf20dff8a5 I'll remove the older patches.

  6. Zash on

    Merged as https://hg.prosody.im/trunk/rev/43b43e7156b8 Sorry about the delay

    Changes
    • tags Milestone-0.12 Status-Fixed
    • owner Zash
  7. Zash on

    Curious, CI fails: https://buildbot.prosody.im/#/builders/7/builds/1061 Passes if I run it locally tho, not sure what's going on.

    Changes
    • tags Status-NeedInfo
  8. Zash on

    Never mind, seems to have been a scansion issue, resolved by updating scansion https://buildbot.prosody.im/#/builders/7/builds/1063

    Changes
    • tags Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.