#1035 mod_pep_plus (trunk) makes devicelist grow very large
Reporter
Martin
Owner
Zash
Created
Updated
Stars
★★ (2)
Tags
Priority-Medium
Status-Fixed
Type-Defect
Milestone-0.11
Martin
on
Running the latest trunk revision I was told that my account was sending an massive amount of notifications making his client break.
I had a look at my pep storage and discovered a very huge devicelist:
du -ah pep* | sort -rh
4.0M pep_eu%2esiacs%2econversations%2eaxolotl%2edevicelist
3.8M pep_eu%2esiacs%2econversations%2eaxolotl%2edevicelist/martin.list
I don't know if this is related but I also saw a lot of this in my debug logs:
grep 'get_pep_service("martin")' ~/var/lib/prosody/prosody.debug
Nov 06 18:27:05 mdosch.de:pep_plus debug get_pep_service("martin")
Nov 06 18:27:05 mdosch.de:pep_plus debug get_pep_service("martin")
Nov 06 18:27:05 mdosch.de:pep_plus debug get_pep_service("martin")
Nov 06 18:27:08 mdosch.de:pep_plus debug get_pep_service("martin")
Nov 06 18:27:08 mdosch.de:pep_plus debug get_pep_service("martin")
Nov 06 18:27:11 mdosch.de:pep_plus debug get_pep_service("martin")
Nov 06 18:27:11 mdosch.de:pep_plus debug get_pep_service("martin")
Nov 06 18:27:11 mdosch.de:pep_plus debug get_pep_service("martin")
and so on.
Also something remarkable in the logs:
Nov 06 18:41:26 c2s8cd3d70 warn Destroying session with 7948 unacked stanzas
About my installation:
prosodyctl about
Prosody hg:af7b41a0ec9e
# Prosody directories
Data directory: /home/md85/var/lib/prosody
Config directory: /home/md85/etc/prosody
Source directory: /home/md85/lib/prosody
Plugin directories:
/home/md85/opt/prosody-modules/ - prosody-modules rev: fd4a5ba12fa2
/home/md85/lib/prosody/modules/
# Lua environment
Lua version: Lua 5.1
Lua module search paths:
/home/md85/lib/prosody/?.lua
/home/md85/.luarocks/share/lua/5.1/?.lua
/home/md85/.luarocks/share/lua/5.1/?/init.lua
/usr/share/lua/5.1/?.lua
/usr/share/lua/5.1/?/init.lua
/home/md85/.luarocks/share/lua/5.1/?.lua
/home/md85/.luarocks/share/lua/5.1/?/init.lua
/usr/lib64/lua/5.1/?.lua
/usr/lib64/lua/5.1/?/init.lua
/home/md85/.luarocks/share/lua/5.1/?.lua
/home/md85/.luarocks/share/lua/5.1/?/init.lua
Lua C module search paths:
/home/md85/lib/prosody/?.so
/home/md85/.luarocks/lib/lua/5.1/?.so
/usr/lib/lua/5.1/?.so
/home/md85/.luarocks/lib/lua/5.1/?.so
/usr/lib64/lua/5.1/?.so
/usr/lib64/lua/5.1/loadall.so
/home/md85/.luarocks/lib/lua/5.1/?.so
LuaRocks: Installed (2.1.2)
# Lua module versions
lfs: LuaFileSystem 1.7.0
libevent: 2.1.8-stable
luaevent: 0.4.4
lxp: LuaExpat 1.3.0
socket: LuaSocket 3.0-rc1
ssl: 0.7
Feel free to ask if there is something missing.
nen
on
Observed a similiar (same?) problem while using trunk with mod_pep_plus from the community-modules. Switching to trunk's built-in pep_plus module seems to help.
Apparently, the community module comes with its own pubsub.lib.lua and util_pubsub.lib.lua. I suspect that the problem is somehow related to the persistent pep item storage.
Running the latest trunk revision I was told that my account was sending an massive amount of notifications making his client break. I had a look at my pep storage and discovered a very huge devicelist: du -ah pep* | sort -rh 4.0M pep_eu%2esiacs%2econversations%2eaxolotl%2edevicelist 3.8M pep_eu%2esiacs%2econversations%2eaxolotl%2edevicelist/martin.list I don't know if this is related but I also saw a lot of this in my debug logs: grep 'get_pep_service("martin")' ~/var/lib/prosody/prosody.debug Nov 06 18:27:05 mdosch.de:pep_plus debug get_pep_service("martin") Nov 06 18:27:05 mdosch.de:pep_plus debug get_pep_service("martin") Nov 06 18:27:05 mdosch.de:pep_plus debug get_pep_service("martin") Nov 06 18:27:08 mdosch.de:pep_plus debug get_pep_service("martin") Nov 06 18:27:08 mdosch.de:pep_plus debug get_pep_service("martin") Nov 06 18:27:11 mdosch.de:pep_plus debug get_pep_service("martin") Nov 06 18:27:11 mdosch.de:pep_plus debug get_pep_service("martin") Nov 06 18:27:11 mdosch.de:pep_plus debug get_pep_service("martin") and so on. Also something remarkable in the logs: Nov 06 18:41:26 c2s8cd3d70 warn Destroying session with 7948 unacked stanzas About my installation: prosodyctl about Prosody hg:af7b41a0ec9e # Prosody directories Data directory: /home/md85/var/lib/prosody Config directory: /home/md85/etc/prosody Source directory: /home/md85/lib/prosody Plugin directories: /home/md85/opt/prosody-modules/ - prosody-modules rev: fd4a5ba12fa2 /home/md85/lib/prosody/modules/ # Lua environment Lua version: Lua 5.1 Lua module search paths: /home/md85/lib/prosody/?.lua /home/md85/.luarocks/share/lua/5.1/?.lua /home/md85/.luarocks/share/lua/5.1/?/init.lua /usr/share/lua/5.1/?.lua /usr/share/lua/5.1/?/init.lua /home/md85/.luarocks/share/lua/5.1/?.lua /home/md85/.luarocks/share/lua/5.1/?/init.lua /usr/lib64/lua/5.1/?.lua /usr/lib64/lua/5.1/?/init.lua /home/md85/.luarocks/share/lua/5.1/?.lua /home/md85/.luarocks/share/lua/5.1/?/init.lua Lua C module search paths: /home/md85/lib/prosody/?.so /home/md85/.luarocks/lib/lua/5.1/?.so /usr/lib/lua/5.1/?.so /home/md85/.luarocks/lib/lua/5.1/?.so /usr/lib64/lua/5.1/?.so /usr/lib64/lua/5.1/loadall.so /home/md85/.luarocks/lib/lua/5.1/?.so LuaRocks: Installed (2.1.2) # Lua module versions lfs: LuaFileSystem 1.7.0 libevent: 2.1.8-stable luaevent: 0.4.4 lxp: LuaExpat 1.3.0 socket: LuaSocket 3.0-rc1 ssl: 0.7 Feel free to ask if there is something missing.
Observed a similiar (same?) problem while using trunk with mod_pep_plus from the community-modules. Switching to trunk's built-in pep_plus module seems to help. Apparently, the community module comes with its own pubsub.lib.lua and util_pubsub.lib.lua. I suspect that the problem is somehow related to the persistent pep item storage.
I believe the cause has been fixed, possibly in https://hg.prosody.im/trunk/rev/f1923a79c93d
Changes