#1084 Traceback on report from mod_s2s_blacklist on trunk
Reporter
Link Mauve
Owner
Nobody
Created
Updated
Stars
★ (1)
Tags
Component-Community
Priority-Medium
Type-Defect
Status-NeedInfo
Link Mauve
on
What steps will reproduce the problem?
1. Use mod_s2s_blacklist.
2. Try to contact a blocked server.
What is the expected output?
I receive an error back.
What do you see instead?
https://prosody.im/pastebin/f9e5cfd7-56c1-4fb4-8bd9-9572fe62fcfa
What version of the product are you using? On what operating system?
8502:c63db78f4ae0 trunk, on ArchLinux.
Please provide any additional information below.
N/A
Zash
on
Looks like a couple of minor weird things comes together to cause this.
mod_dialback is sending a stanza with "db:verify" as name in the default namespace
mod_s2s_blacklist catches it and attempts to send back an error reply
nothing handles the reply so it goes to deal with unhandled stanzas
because how the stanza name is not "message", "presence" or "iq" it goes to kill the origin for sending something invalid
the origin is mod_s2s_blacklist, or rather the host it is loaded on
host sessions can't be closed
boom!
I don't quite know where to begin...
No, this changeset did fix the traceback, I now have a bunch of these instead:
Attempt to close host session jabber.fr with reason: unsupported-stanza-type
What steps will reproduce the problem? 1. Use mod_s2s_blacklist. 2. Try to contact a blocked server. What is the expected output? I receive an error back. What do you see instead? https://prosody.im/pastebin/f9e5cfd7-56c1-4fb4-8bd9-9572fe62fcfa What version of the product are you using? On what operating system? 8502:c63db78f4ae0 trunk, on ArchLinux. Please provide any additional information below. N/A
Looks like a couple of minor weird things comes together to cause this. mod_dialback is sending a stanza with "db:verify" as name in the default namespace mod_s2s_blacklist catches it and attempts to send back an error reply nothing handles the reply so it goes to deal with unhandled stanzas because how the stanza name is not "message", "presence" or "iq" it goes to kill the origin for sending something invalid the origin is mod_s2s_blacklist, or rather the host it is loaded on host sessions can't be closed boom! I don't quite know where to begin...
Changeshttps://hg.prosody.im/trunk/rev/d5d746e4c453 should turn the traceback into a log message
Is this still an issue?
ChangesNo, this changeset did fix the traceback, I now have a bunch of these instead: Attempt to close host session jabber.fr with reason: unsupported-stanza-type