#1118 mod_mam_muc should not announce mam:2 on 0.10 stable
Reporter
lovetox
Owner
MattJ
Created
Updated
Stars
★★ (2)
Tags
Status-Fixed
Type-Defect
Priority-Medium
Component-Community
lovetox
on
What steps will reproduce the problem?
1. write a message in a muc while the server runs mod_mam_muc on 0.10
2. no stanza-id is added to the message although mam:2 is announced
What is the expected output?
stanza-id should be added or mam:1 should be announced
What do you see instead?
mam:2 is announced
What version of the product are you using? On what operating system?
0.10 stable / all
Please provide any additional information below.
Opened just for tracking purposes.
Solution would be to make a condition between 0.10 and trunk.
The problem is not present anymore in trunk
Just to explain the reason behind this bug, from Zash in xmpp:prosody@conference.prosody.im
"Thing is that in 0.10, when mod_mam_myc gets messages, they have already been sent, so too late to add the id tag"
So a workaround is to use mod_muc from trunk, which should work in Prosody 0.10.
ValdikSS
on
Is it possible to advertise mam:0 too? Conversations checks only mam:2 and mam:0, and marks MAM as unavailable if none found.
MattJ
on
It's not possible to advertise mam:0, because the module does not implement mam:0. It advertises what it implements (which is the reason that advertising mam:2 was a bug - it doesn't implement mam:2, and advertising it will break clients).
ValdikSS
on
MattJ, the latest change broke Conversations MAM support in MUC for Prosody 0.10.
What steps will reproduce the problem? 1. write a message in a muc while the server runs mod_mam_muc on 0.10 2. no stanza-id is added to the message although mam:2 is announced What is the expected output? stanza-id should be added or mam:1 should be announced What do you see instead? mam:2 is announced What version of the product are you using? On what operating system? 0.10 stable / all Please provide any additional information below. Opened just for tracking purposes. Solution would be to make a condition between 0.10 and trunk. The problem is not present anymore in trunk
Fixed in https://hg.prosody.im/prosody-modules/rev/39994c6bb314 Thanks for reporting!
ChangesJust to explain the reason behind this bug, from Zash in xmpp:prosody@conference.prosody.im "Thing is that in 0.10, when mod_mam_myc gets messages, they have already been sent, so too late to add the id tag" So a workaround is to use mod_muc from trunk, which should work in Prosody 0.10.
Is it possible to advertise mam:0 too? Conversations checks only mam:2 and mam:0, and marks MAM as unavailable if none found.
It's not possible to advertise mam:0, because the module does not implement mam:0. It advertises what it implements (which is the reason that advertising mam:2 was a bug - it doesn't implement mam:2, and advertising it will break clients).
MattJ, the latest change broke Conversations MAM support in MUC for Prosody 0.10.