#1127 mod_csi_battery_saver: set CSI-active on resume, not on hibernation

Reporter Ge0rG
Owner Nobody
Stars ★ (1)
  • Type-Defect
  • Status-Fixed
  • Priority-Medium
  • Component-Community
  1. Ge0rG on

    mod_csi_battery_saver will set CSI state to "active" and flush the queue when a smacks-enabled session is hibernated. This interacts very badly with mod_cloud_notify, which will see new stanzas in the smacks queue and trigger a push notification to wake up the device. Please change the behavior to keep smacks-hibernated sessions as CSI-inactive (or maybe even explicitly make them "inactive" on hibernation), and to only reset to active when the session is resumed (but prior to processing any stanzas from the resumed session, as those might contain another CSI-inactive setting). This also has the benefit of flushing the queue at a moment when we know the client is most probably there and listening.

  2. Zash on

    • tags Component-Community
  3. Zash on

    Thanks for the report. This has been fixed according to tmolitor

    • tags Status-Fixed
  4. tmolitor on

    fixed in https://hg.prosody.im/prosody-modules/rev/75930e4c2478

New comment

Not published. Used for spam prevention and optional update notifications.