#1180 mod_groups: No logging for invalid JIDs

Reporter Meaz
Owner Zash
Created
Updated
Stars ★★ (2)
Tags
  • Priority-Medium
  • Type-Defect
  • Milestone-0.10
  • Status-Fixed
  1. Meaz on

    I enabled mod_group and create a group.txt with: [Teachers] meaz@myserver=Maxime denarhill@myserver=Dennis emiliamln‎@myserver=Emilia For some reason, emiliamln‎@myserver doesn't appear in the group. Here is what I have in the logs for her: Jul 07 17:42:25 myserver:groups debug New group: Teachers Jul 07 17:42:25 myserver:groups debug entryjid = 'emiliamln@myserver', name = '' Jul 07 17:42:25 myserver:groups debug New member of Teachers: emiliamln@myserver Jul 07 17:42:25 myserver:groups debug entryjid = '', name = '' entryjid = '', name = '' isn't empty for the two other ones that work...

  2. Meaz on

    It now works: the contact has to accept the invitation before it works.

  3. Zash on

    I was going test this, so I saved the text in the issue into a file. When opening that file, I see: emiliamln<200e>@myserver=Emilia What is that U+200E LEFT-TO-RIGHT MARK doing there? It is not valid in JIDs. From looking at the code, I'm guessing the JID fails to validate and is ignored. There is no logging for that however, which is probably a bug. And no, mod_groups overrides rosters so you don't need to accept invites.

    Changes
    • tags Status-Accepted
    • owner Zash
  4. Zash on

    Changes
    • title mod_group entryjid = '' mod_groups: No logging for invalid JIDs
  5. Zash on

    Extra logging added in https://hg.prosody.im/0.10/rev/37ebcc7c6768 Poke or open a new issue if you can reproduce the problem without seeing that log message.

    Changes
    • tags Milestone-0.10 Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.