#1239 Use net.connect for outgoing s2s connections
Reporter
Zash
Owner
Zash
Created
Updated
Stars
★ (1)
Tags
Component-S2S
Status-Fixed
Type-Enhancement
Priority-Medium
Milestone-0.12
Zash
on
Description of feature:
Currently mod_s2s/s2sout implements SRV aware connection establishment for s2s.
Since the new net.connect API is meant to replace handling of outgoing connections,
this should eventually also be used for s2s.
Motivation:
- Code reduction and reuse
- Getting net.resolvers.service ready
- Easier future extension eg for _xmpps-server
So I've actually have a patch for this already, however I'm sitting on it for now due to known and unknown regressions compared to mod_s2s/s2sout which it replaces completely.
Description of feature: Currently mod_s2s/s2sout implements SRV aware connection establishment for s2s. Since the new net.connect API is meant to replace handling of outgoing connections, this should eventually also be used for s2s. Motivation: - Code reduction and reuse - Getting net.resolvers.service ready - Easier future extension eg for _xmpps-server
I was asked to link this here: https://issues.prosody.im/1246
So I've actually have a patch for this already, however I'm sitting on it for now due to known and unknown regressions compared to mod_s2s/s2sout which it replaces completely.
ChangesBlocked by #1263
Done in https://hg.prosody.im/trunk/rev/756b8821007a
Changes