#1504 mod_mam: cleanup_runner blocking server operations
Reporter
ge0rg
Owner
Zash
Created
Updated
Stars
★★ (2)
Tags
Type-Defect
Status-Fixed
Priority-Medium
Milestone-0.11
ge0rg
on
Running 0.11.x mod_mam backed by SQLite on a medium-sized production server.
The periodic cleanup_runner task will run from async, but still block the prosody server for longer intervals - on the specific installation for roughly 30 seconds each time it triggers, which is after 4h.
Could you please add a delay, or a yield() kind of thing, into the inner loop between the individual user archive deletions, so that the server gets a chance to work up on pending network activities?
Zash
on
Thanks for the report.
Have a patch, wondering what's the best pause time between each step.
Changes
owner Zash
tags Milestone-0.11 Status-Started
Zash
on
Fixed in s(hg link|sed s/trunk/0.11/). Please test.
Running 0.11.x mod_mam backed by SQLite on a medium-sized production server. The periodic cleanup_runner task will run from async, but still block the prosody server for longer intervals - on the specific installation for roughly 30 seconds each time it triggers, which is after 4h. Could you please add a delay, or a yield() kind of thing, into the inner loop between the individual user archive deletions, so that the server gets a chance to work up on pending network activities?
Thanks for the report. Have a patch, wondering what's the best pause time between each step.
ChangesFixed in s(hg link|sed s/trunk/0.11/). Please test.
ChangesGah, link is https://hg.prosody.im/0.11/rev/62ef68f95b6f