#1517 MUC: Error on asking for voice without being in room
Reporter
Zash
Owner
Nobody
Created
Updated
Stars
★★ (2)
Tags
Difficulty-Easy
Priority-Medium
Type-Defect
Status-Accepted
Zash
on
What steps will reproduce the problem?
Given an existing MUC room@muc.example.com send a voice request without joining first:
<message to="room@muc.example.com" type="normal">
<x xmlns="jabber:x:data">
<field var="FORM_TYPE">
<value>http://jabber.org/protocol/muc#request</value>
</field>
</x>
</message>
What is the expected output?
Some kind of error stanza probably.
What do you see instead?
21:11:58 c2s5613c0ca3990 error Traceback[c2s]: plugins/muc/request.lib.lua:67: attempt to index a nil value (local 'occupant')
stack traceback:
plugins/muc/request.lib.lua:67: in method 'handle_role_request'
plugins/muc/muc.lib.lua:1274: in function <plugins/muc/muc.lib.lua:1250>
(...tail calls...)
./util/events.lua:79: in function <./util/events.lua:75>
(...tail calls...)
./core/stanza_router.lua:188: in upvalue 'core_post_stanza'
./core/stanza_router.lua:128: in upvalue 'core_process_stanza'
plugins/mod_c2s.lua:283: in upvalue 'func'
./util/async.lua:127: in function <./util/async.lua:125>
What version of the product are you using?
Reproduced on 0.11.0 forward including trunk, presumably since #655
What steps will reproduce the problem? Given an existing MUC room@muc.example.com send a voice request without joining first: <message to="room@muc.example.com" type="normal"> <x xmlns="jabber:x:data"> <field var="FORM_TYPE"> <value>http://jabber.org/protocol/muc#request</value> </field> </x> </message> What is the expected output? Some kind of error stanza probably. What do you see instead? 21:11:58 c2s5613c0ca3990 error Traceback[c2s]: plugins/muc/request.lib.lua:67: attempt to index a nil value (local 'occupant') stack traceback: plugins/muc/request.lib.lua:67: in method 'handle_role_request' plugins/muc/muc.lib.lua:1274: in function <plugins/muc/muc.lib.lua:1250> (...tail calls...) ./util/events.lua:79: in function <./util/events.lua:75> (...tail calls...) ./core/stanza_router.lua:188: in upvalue 'core_post_stanza' ./core/stanza_router.lua:128: in upvalue 'core_process_stanza' plugins/mod_c2s.lua:283: in upvalue 'func' ./util/async.lua:127: in function <./util/async.lua:125> What version of the product are you using? Reproduced on 0.11.0 forward including trunk, presumably since #655