#161 DNS records not normalized in cache

Reporter agoode
Owner MattJ
Created
Updated
Stars ★ (1)
Tags
  • Priority-Medium
  • Milestone-0.7
  • Type-Defect
  • Status-Fixed
  1. agoode on

    *What steps will reproduce the problem?* 1. Try to federate with a domain that does not have SRV records, but does have a CNAME. *What is the expected output? What do you see instead?* Expected: success. Actual: Feb 11 09:37:12 s2smanager debug First attempt to connect to coda.cs.cmu.edu, starting with SRV lookup... Feb 11 09:37:12 adns debug Records for _xmpp- server._tcp.coda.cs.cmu.edu. not in cache, sending query (thread: 0x833f688)... Feb 11 09:37:12 s2smanager debug DNS lookup for coda.cs.cmu.edu sent, waiting for response before we can connect Feb 11 09:37:12 s2smanager debug stanza [presence] queued until connection complete Feb 11 09:37:12 adns debug Reply for _xmpp- server._tcp.coda.cs.cmu.edu. (thread: 0x833f688) Feb 11 09:37:12 s2smanager debug coda.cs.cmu.edu has no SRV records, falling back to A Feb 11 09:37:12 adns debug Records for coda.cs.cmu.edu not in cache, sending query (thread: 0x841c5f0)... Feb 11 09:37:12 socket debug server.lua: closed client handler and removed socket from list Feb 11 09:37:12 adns debug Reply for coda.cs.cmu.edu (thread: 0x841c5f0) Feb 11 09:37:12 s2smanager debug Looking up TELEMANN.coda.cs.cmu.edu. (DNS depth is 3) Feb 11 09:37:12 s2smanager debug DNS lookup failed to get a response for coda.cs.cmu.edu Feb 11 09:37:12 s2sout8433650 info Out of connection options, can't connect to coda.cs.cmu.edu Feb 11 09:37:12 s2smanager debug No other records to try for coda.cs.cmu.edu - destroying Feb 11 09:37:12 s2sout8433650 info Destroying outgoing session spicenitz.org->coda.cs.cmu.edu Feb 11 09:37:12 s2sout8433650 info sending error replies for 2 queued stanzas because of failed outgoing connection to coda.cs.cmu.edu *What version of the product are you using? On what operating system?* 0.6.1, Debian *Please provide any additional information below.* It looks like adns is not populating the cache with the A record, so the peek in the callback is failing?

  2. MattJ on

    Thanks, I'll take a look.

    Changes
    • tags Milestone-0.7 Status-Accepted
    • owner MattJ
  3. MattJ on

    The issue was that the CNAME target was "TELEMANN.coda.cs.cmu.edu" (ie. in capitals). Records were not being normalized before going into the cache, and so the record wasn't found when searching for CNAME candidates. Thanks for reporting, the fix is in http://prosody.im/changeset/481c6724818f and will be released in 0.7 shortly.

    Changes
    • tags Status-Fixed
    • title DNS records not normalized in cache
  4. agoode on

    Nice! Thanks!

New comment

Not published. Used for spam prevention and optional update notifications.