#1709 util.pubsub does not properly unsubscribe JIDs on affiliation changes
Reporter
Jonas Schäfer
Owner
Nobody
Created
Updated
Stars
★ (1)
Tags
Type-Defect
Security
Milestone-13.0
Status-Fixed
Priority-High
Jonas Schäfer
on
Three chained issues:
1. there seems to be a typo https://hg.prosody.im/trunk/file/tip/util/pubsub.lua#l304: add should be remove here
2. jid_sub rarely is true if the affiliation is managed for a bare JID, because subscriptions are often full JIDs
3. remove_subscription would then also not find the correct subscription because it searches by an exact JID match (and there's again the full vs. bare JID mismatch)
Three chained issues: 1. there seems to be a typo https://hg.prosody.im/trunk/file/tip/util/pubsub.lua#l304: add should be remove here 2. jid_sub rarely is true if the affiliation is managed for a bare JID, because subscriptions are often full JIDs 3. remove_subscription would then also not find the correct subscription because it searches by an exact JID match (and there's again the full vs. bare JID mismatch)
Fixed in https://hg.prosody.im/trunk/rev/888d0c52db41
ChangesHiddenMilestone-13.0 Status-Fixed