#1735 config: uncaught error if virtualhost provided with a module name
Reporter
MattJ
Owner
MattJ
Created
Updated
Stars
★ (1)
Tags
Milestone-0.12
Type-Defect
Priority-Medium
Status-Fixed
MattJ
on
What steps will reproduce the problem?
1. Add an invalid config file line: VirtualHost "example.com" "muc"
What is the expected output?
Prosody should tell the user that this is invalid.
What do you see instead?
Error: /usr/lib/prosody/core/configmanager.lua:134 : bad argument #1 to 'pairs' (table expected, got string)
What version of the product are you using? On what operating system?
Encountered by user of 0.11.x, confirmed by me in 0.12.0.
Given that this config mistake seems pretty uncommon, I intend to only fix it in 0.12.x.
What steps will reproduce the problem? 1. Add an invalid config file line: VirtualHost "example.com" "muc" What is the expected output? Prosody should tell the user that this is invalid. What do you see instead? Error: /usr/lib/prosody/core/configmanager.lua:134 : bad argument #1 to 'pairs' (table expected, got string) What version of the product are you using? On what operating system? Encountered by user of 0.11.x, confirmed by me in 0.12.0. Given that this config mistake seems pretty uncommon, I intend to only fix it in 0.12.x.
Fixed for 0.12 in https://hg.prosody.im/trunk/rev/fb7e76c1ad1c
Changes