#1736 Incorrect logging of new http apps

Reporter Zash
Owner Zash
Created
Updated
Stars ★ (1)
Tags
  • Priority-Medium
  • Type-Defect
  • Milestone-0.12
  • Status-Fixed
  1. Zash on

    What steps will reproduce the problem? 1. Load module providing a http app via mod_http in a VirtualHost context 2. Observe logs What is the expected output? virtualhost.example:http info Serving 'exampleapp' at https://virtualhost.example:5281/exampleapp What do you see instead? virtualhost.example:http info Serving 'exampleapp' at https://*:5281/exampleapp What version of the product are you using? Observed on 0.12.0, recent trunk and ever since https://hg.prosody.im/trunk/rev/6ec3fbae05c9 Please provide any additional information below. This happens because the `module` proxy object passed to `module.add_host()` does not override the `global` property, so it exposes the actual global module (mod_http) context, preventing the logic in 6ec3fbae05c9 form behaving as intended.

  2. Zash on

    Fixed in https://hg.prosody.im/trunk/rev/7efd4bcaa95c

    Changes
    • tags Status-Fixed
    • owner Zash
  3. Zash on

    #1748 is a similar issue

New comment

Not published. Used for spam prevention and optional update notifications.