#1740 mod_storage_xep0227 tracebacks reading non-existent PEP store

Reporter MattJ
Owner MattJ
Created
Updated
Stars ★ (1)
Tags
  • Status-Fixed
  • Milestone-0.12
  • Type-Defect
  • Priority-Medium
  1. MattJ on

    What steps will reproduce the problem? 1. Import a XEP-0227 file that is missing {http://jabber.org/protocol/pubsub#owner}pubsub 2. Attempt to read from the 'pep' store What is the expected output? If no PEP store exists in the XML, it should return nil. What do you see instead? /usr/lib/prosody/modules/mod_storage_xep0227.lua:302: attempt to index local 'owner_el' (a nil value) What version of the product are you using? On what operating system? Prosody trunk something something, but this code is unchanged since 0.12. Please provide any additional information below. migrate.modernxmpp.org exports XML files with no PEP data. This is breaking import from migrate.modernxmpp.org to Snikket instances.

  2. Zash on

    Fixed in https://hg.prosody.im/trunk/rev/b2438f374b3e Further improvement in https://hg.prosody.im/trunk/rev/8b7895266e99 to allow migration of PEP <items/> data in the absence of the pubsub#owner element

    Changes
    • owner MattJ
    • tags Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.