#1841 mod_server_contact_info and mod_pubsub_serverinfo add separate forms to disco#info
Reporter
Ge0rG
Owner
MattJ
Created
Updated
Stars
★ (1)
Tags
Priority-Medium
Compliance
Status-Started
Type-Defect
Ge0rG
on
When loading both server_contact_info and pubsub_serverinfo, both modules add their own data form to the disco#info response:
```
<iq type="result" from="yax.im" id="a5d212106831404d9f9c1ff33c6201d3" to="...">
<query xmlns="http://jabber.org/protocol/disco#info">
<identity type="im" name="Prosody" category="server"/>
<!-- snipped features -->
<x xmlns="jabber:x:data" type="result">
<field type="hidden" var="FORM_TYPE">
<value>http://jabber.org/network/serverinfo</value>
</field>
<field type="text-single" var="serverinfo-pubsub-node">
<value>xmpp:pubsub.yax.im?;node=serverinfo</value>
</field>
</x>
<x xmlns="jabber:x:data" type="result">
<field type="hidden" var="FORM_TYPE">
<value>http://jabber.org/network/serverinfo</value>
</field>
<field type="list-multi" var="abuse-addresses">
<value>mailto:georg@yax.im</value>
<value>xmpp:georg@yax.im</value>
</field>
<field type="list-multi" var="admin-addresses">
<value>mailto:georg@yax.im</value>
<value>xmpp:georg@yax.im</value>
</field>
<field type="list-multi" var="feedback-addresses"/>
<field type="list-multi" var="sales-addresses"/>
<field type="list-multi" var="security-addresses">
<value>xmpp:georg@yax.im</value>
</field>
<field type="list-multi" var="status-addresses"/>
<field type="list-multi" var="support-addresses">
<value>xmpp:yaxim@chat.yax.im?join</value>
</field>
</x>
</query>
</iq>
```
Instead, all fields should be consolidated into one form.
MattJ
on
This is now fixed if you update the module *and* you use Prosody trunk (from tomorrow's nightly).
A fix for 0.12 would require a new contact info plugin, which uses the new API in mod_server_info.
Changes
owner MattJ
tags Status-Started
Zash
on
Is the intent to provide a fix for 0.12? No Milestone is set here.
Ge0rG
on
There is now mod_server_info and mod_server_contact_info in prosody-modules, and loading those (and re-loading mod_pubsub_serverinfo) will make it work on 0.12. Thanks very much!
When loading both server_contact_info and pubsub_serverinfo, both modules add their own data form to the disco#info response: ``` <iq type="result" from="yax.im" id="a5d212106831404d9f9c1ff33c6201d3" to="..."> <query xmlns="http://jabber.org/protocol/disco#info"> <identity type="im" name="Prosody" category="server"/> <!-- snipped features --> <x xmlns="jabber:x:data" type="result"> <field type="hidden" var="FORM_TYPE"> <value>http://jabber.org/network/serverinfo</value> </field> <field type="text-single" var="serverinfo-pubsub-node"> <value>xmpp:pubsub.yax.im?;node=serverinfo</value> </field> </x> <x xmlns="jabber:x:data" type="result"> <field type="hidden" var="FORM_TYPE"> <value>http://jabber.org/network/serverinfo</value> </field> <field type="list-multi" var="abuse-addresses"> <value>mailto:georg@yax.im</value> <value>xmpp:georg@yax.im</value> </field> <field type="list-multi" var="admin-addresses"> <value>mailto:georg@yax.im</value> <value>xmpp:georg@yax.im</value> </field> <field type="list-multi" var="feedback-addresses"/> <field type="list-multi" var="sales-addresses"/> <field type="list-multi" var="security-addresses"> <value>xmpp:georg@yax.im</value> </field> <field type="list-multi" var="status-addresses"/> <field type="list-multi" var="support-addresses"> <value>xmpp:yaxim@chat.yax.im?join</value> </field> </x> </query> </iq> ``` Instead, all fields should be consolidated into one form.
This is now fixed if you update the module *and* you use Prosody trunk (from tomorrow's nightly). A fix for 0.12 would require a new contact info plugin, which uses the new API in mod_server_info.
ChangesIs the intent to provide a fix for 0.12? No Milestone is set here.
There is now mod_server_info and mod_server_contact_info in prosody-modules, and loading those (and re-loading mod_pubsub_serverinfo) will make it work on 0.12. Thanks very much!