#1859 mod_pubsub: bad implementation of retractation notifications

Reporter John Livingston
Owner Nobody
Stars ★ (1)
  • Compliance
  • Type-Defect
  • Priority-Medium
  • Status-New
  1. John Livingston on

    Hello, XEP-0060 (https://xmpp.org/extensions/xep-0060.html) mention a "pubsub#notify_retract" configuration field, to enable notification for retracts. This field is declared in "node_config_form", with a default value of true. It is tested in function "simple_broadcast" in "plugins/mod_pubsub/mod_pubsub.lua" (for example, same in mod_pep). XEP-0060 also says (https://xmpp.org/extensions/xep-0060.html#publisher-delete-request): "If no error occurs and the <retract/> element included a 'notify' attribute with a value of "true" or "1" [15], then the service MUST delete the item and MUST notify all subscribers as shown below. The syntax is identical to event notifications except that instead of an <item/> element, the <items/> element includes a <retract/> element." This means that, if there is a "notify" attribute, the retract must be broadcasted, even if "pubsub#notify_retract" is false. But the code in "handlers.set_retract" only read the "notify" attribute, and don't send any broadcast if this attribute is not true. Even if the configuration says that we want retract notifications. Seems this is not fully XEP-0060 compliant.

New comment

Not published. Used for spam prevention and optional update notifications.