#1861 mod_carbons does not forward "sent" MUC PMs to other clients
Reporter
ge0rg
Owner
MattJ
Created
Updated
Stars
★★ (2)
Tags
Priority-Medium
Compliance
Type-Defect
Milestone-13.0
Status-Fixed
ge0rg
on
https://xmpp.org/extensions/xep-0280.html#recommended-rules says:
> A private <message/> from a local user to a MUC participant (sent to a full JID) SHOULD be carbon-copied [7].
The advertised "urn:xmpp:carbons:rules:0" feature converts that SHOULD into a MUST.
Also relevant, footnote #7:
> The server SHOULD limit carbon-copying to the clients sharing a Multi-Session Nick in that MUC, and MAY inject the <x/> element into such carbon copies.
This is not required behavior, as it would require tracking MUC presence from all clients, but not forwarding "sent" PMs means that all other joined clients only get half of the conversation.
Actual behavior:
May 13 10:57:04 yax.im:carbons debug Not copying stanza: <message from='georg@yax.im/poezio-IS8H' type='chat' id='84fc69bcff494b2aa8ed90bd7d01ef2e' to='room@remote-domain/nickname'> (muc-pm)
MattJ
on
Fixed in https://hg.prosody.im/trunk/rev/d7f2ffc25273
Details are in the commit message, but the summary is that this was already implemented but broke during some refactoring that was released in 0.12.0. It was not the only carbons-related behaviour that was broken.
The above commit fixes the refactoring bug, and carbons should be fully working again.
https://xmpp.org/extensions/xep-0280.html#recommended-rules says: > A private <message/> from a local user to a MUC participant (sent to a full JID) SHOULD be carbon-copied [7]. The advertised "urn:xmpp:carbons:rules:0" feature converts that SHOULD into a MUST. Also relevant, footnote #7: > The server SHOULD limit carbon-copying to the clients sharing a Multi-Session Nick in that MUC, and MAY inject the <x/> element into such carbon copies. This is not required behavior, as it would require tracking MUC presence from all clients, but not forwarding "sent" PMs means that all other joined clients only get half of the conversation. Actual behavior: May 13 10:57:04 yax.im:carbons debug Not copying stanza: <message from='georg@yax.im/poezio-IS8H' type='chat' id='84fc69bcff494b2aa8ed90bd7d01ef2e' to='room@remote-domain/nickname'> (muc-pm)
Fixed in https://hg.prosody.im/trunk/rev/d7f2ffc25273 Details are in the commit message, but the summary is that this was already implemented but broke during some refactoring that was released in 0.12.0. It was not the only carbons-related behaviour that was broken. The above commit fixes the refactoring bug, and carbons should be fully working again.
Changes