#1878 MUC roomconfig are saved even if there are validation errors
Reporter
John Livingston
Owner
Nobody
Created
Updated
Stars
★ (1)
Tags
Status-New
Type-Defect
Priority-Medium
John Livingston
on
When you submit a MUC roomconfig, the data validation does not prevent the form to be saved.
There is a five year old `-- FIXME handle form errors` in muc.lib.lua.
There should be something like:
```
if errors then
origin.send(st.error_reply(stanza, "modify", "bad-request", dataform_error_message(errors)));
return true;
end
```
Where dataform_error_message constructs the error message (as in pubsub.lib.lua for example)
When you submit a MUC roomconfig, the data validation does not prevent the form to be saved. There is a five year old `-- FIXME handle form errors` in muc.lib.lua. There should be something like: ``` if errors then origin.send(st.error_reply(stanza, "modify", "bad-request", dataform_error_message(errors))); return true; end ``` Where dataform_error_message constructs the error message (as in pubsub.lib.lua for example)