#1909 Merge mod_csi_battery_saver features in mod_csi_simple
Reporter
lissine
Owner
Nobody
Created
Updated
Stars
★★ (3)
Tags
Type-Enhancement
Status-NeedInfo
Priority-Medium
lissine
on
The battery_saver community module ( https://modules.prosody.im/mod_csi_battery_saver.html ) is based on the csi_simple module, and it adds the following features:
- accepting / denying contact requests is important. (Some clients show a notification for new contact requests).
Thus if the contact request is acted upon in a client, other clients will remove the notification.
- support for MDS (XEP-0490) --> removing notifications for messages displayed on another device
- better support for old-style OpenPGP (XEP-0027)
It would be nice to merge these features in mod_csi_simple
Zash
on
Thanks for your requests.
> MDS
I had missed that this was stable already. From a quick read I see there's some text about optional server-side support, I think the way forward is to build a new module that implements the server-side of MDS and uses the event fired by mod_csi_simple to signal that its events should be high priority.
> old-style OpenPGP
I would rather keep it unaware of specific E2EE methods and rely only on XEP-0380. Otherwise it becomes a race to keep up with new versions of OMEMO and others and there are enough of those already.
Consider asking clients that implement OldPGP to implement XEP-0380.
> accepting / denying contact requests
Strange, those should be high prio already, via this path:
https://hg.prosody.im/trunk/file/13.0.0/plugins/mod_csi_simple.lua#l41
Also all <iq> stanzas are high priority, which should include roster and blocklist pushes.
Can you provide more details about what kind of stanza you are referring to and which rule it runs into?
Changes
tags Status-NeedInfo
tmolitor
on
> MDS
until that module is written, we probably should add some rules in mod_csi_simple. you can just copy over these from mod_csi_battery_saver, if you want :)
> old-style OpenPGP
well, I'm fine with that
> accepting / denying contact requests
yes you are right, I missed that one
The battery_saver community module ( https://modules.prosody.im/mod_csi_battery_saver.html ) is based on the csi_simple module, and it adds the following features: - accepting / denying contact requests is important. (Some clients show a notification for new contact requests). Thus if the contact request is acted upon in a client, other clients will remove the notification. - support for MDS (XEP-0490) --> removing notifications for messages displayed on another device - better support for old-style OpenPGP (XEP-0027) It would be nice to merge these features in mod_csi_simple
Thanks for your requests. > MDS I had missed that this was stable already. From a quick read I see there's some text about optional server-side support, I think the way forward is to build a new module that implements the server-side of MDS and uses the event fired by mod_csi_simple to signal that its events should be high priority. > old-style OpenPGP I would rather keep it unaware of specific E2EE methods and rely only on XEP-0380. Otherwise it becomes a race to keep up with new versions of OMEMO and others and there are enough of those already. Consider asking clients that implement OldPGP to implement XEP-0380. > accepting / denying contact requests Strange, those should be high prio already, via this path: https://hg.prosody.im/trunk/file/13.0.0/plugins/mod_csi_simple.lua#l41 Also all <iq> stanzas are high priority, which should include roster and blocklist pushes. Can you provide more details about what kind of stanza you are referring to and which rule it runs into?
Changes> MDS until that module is written, we probably should add some rules in mod_csi_simple. you can just copy over these from mod_csi_battery_saver, if you want :) > old-style OpenPGP well, I'm fine with that > accepting / denying contact requests yes you are right, I missed that one