What steps will reproduce the problem? 1. Request the roster with a client. 2. Send a directed <presence type="subscribed"/> stanza to a JID who currently either is not on your roster or whose roster item has subscription="none" or subscription="to", thus pre-approving the potential contact's subscription. 3. Read the roster push that is sent to the client. What is the expected output? <iq type="set" id="some cool id value"> <query xmlns="jabber:iq:roster"> <item jid="some@cool.jid.example" subscription="none" approved="true"/> </query> </iq> What do you see instead? <iq type="set" id="some cool id value"> <query xmlns="jabber:iq:roster"> <item jid="some@cool.jid.example" subscription="none"/> </query> </iq> What version of the product are you using? On what operating system? Prosody 13.0.1 on Gentoo. The issue is present on trunk at the time of writing. Please provide any additional information below. At the time of writing, it is at line 70 in core/rostermanager.lua - the table should include `approved = item.approved`.

Thanks for the report, and for the patch sent to the mailing list. We'll look at it soon.

• tags Patch Status-Accepted