#1940 Update documentation on mod_http_file_share retention setting for 0.12 versions
Reporter
bunnydear
Owner
Nobody
Created
Updated
Stars
★ (1)
Tags
Priority-Medium
Status-New
Component-Docs
Type-Defect
bunnydear
on
https://prosody.im/doc/modules/mod_http_file_share
reads
-----------------------------
Retention
Files are stored for a week by default, matching the default retention period of mod_mam. To change this set the http_file_share_expires_after to the desired retention period.
Component "upload.example.org" "http_file_share"
http_file_share_expires_after = "31 days"
In Prosody 0.12.x this setting is a number in seconds.
Setting to "never" disables expiry of uploaded files.
-----------------------------------
Please remove "matching the default retention period of mod_mam" because that easily suggests as if the module uses that setting if not set explicitly. It shredded quite some uploads unintentionally of this misunderstanding with me.
Put line Setting to "never" disables expiry of uploaded files. BEFORE the line about the 0.12.x as it is not applicable to 0.12.x !
While using Prosody 0.12.3 and likely all 0.12+ versions, setting
http_file_share_expires_after = "never"
or
http_file_share_expires_after = 0
do NOT work. Also, using Conversejs as front-end, its paperclip vanishes.
Present version 0.13x DOES support the "never" setting.
The mod_http_file_share.lua source of version 0.12 does not parse "never" and 0 means "no retention at all".
For version 0.12.3 (= present version for Raspberry Pi B+ on Debian Bookworm), setting expiry to "never" requires
http_file_share_expires_after = <big number like 9999999999 seconds>
http_file_share_expires_after = math.huge
or
http_file_share_expires_after = -1
Please include those settings for the 0.12 versions.
bunnybear
on
http_file_share_expires_after = math.huge
won't work. It assigns (nil) to the expiry variable and throws an error due to
expiry >= 0
according to the module's source.
https://prosody.im/doc/modules/mod_http_file_share reads ----------------------------- Retention Files are stored for a week by default, matching the default retention period of mod_mam. To change this set the http_file_share_expires_after to the desired retention period. Component "upload.example.org" "http_file_share" http_file_share_expires_after = "31 days" In Prosody 0.12.x this setting is a number in seconds. Setting to "never" disables expiry of uploaded files. ----------------------------------- Please remove "matching the default retention period of mod_mam" because that easily suggests as if the module uses that setting if not set explicitly. It shredded quite some uploads unintentionally of this misunderstanding with me. Put line Setting to "never" disables expiry of uploaded files. BEFORE the line about the 0.12.x as it is not applicable to 0.12.x ! While using Prosody 0.12.3 and likely all 0.12+ versions, setting http_file_share_expires_after = "never" or http_file_share_expires_after = 0 do NOT work. Also, using Conversejs as front-end, its paperclip vanishes. Present version 0.13x DOES support the "never" setting. The mod_http_file_share.lua source of version 0.12 does not parse "never" and 0 means "no retention at all". For version 0.12.3 (= present version for Raspberry Pi B+ on Debian Bookworm), setting expiry to "never" requires http_file_share_expires_after = <big number like 9999999999 seconds> http_file_share_expires_after = math.huge or http_file_share_expires_after = -1 Please include those settings for the 0.12 versions.
http_file_share_expires_after = math.huge won't work. It assigns (nil) to the expiry variable and throws an error due to expiry >= 0 according to the module's source.