For the record, this isn't a compliance issue IMHO. The RFC does not say we MUST NOT support 5223 :) In fact we support lots of things that are not in the RFC.
Also note that it is disabled by default, very few installations have it enabled. The ones that do probably have a reason for it.
I'm +1 to moving it into a module though, if it cuts down on code elsewhere. I suspect though that it won't really.
Changes
tagsType-Defect Type-Enhancement
title Remove support for legacy SSL (port 5223)
Waqas
on
It doesn't seem to cut code elsewhere AFAICS (other than moving that net-provider out of mod_c2s)
MattJ
on
There are deployments that need this (some people argue that 5223 should be standardized, because it's useful).
We might move it into a module, but the benefits don't seem worth it for a few lines of code. Closing for now.
Can you remove the old 5223 port support? Respect XMPP RFCs: - https://tools.ietf.org/html/rfc3920 (Obsoleted by: 6120) - https://tools.ietf.org/html/rfc6120 (Last version)
-- mod_legacy_ssl module:set_global(); module:depends("c2s"); local c2s_listener = portmanager.get_service("c2s").listener; module:provides("net", { name = "legacy_ssl"; listener = c2s_listener; encryption = "ssl"; multiplex = { pattern = "^<.*:stream.*%sxmlns%s*=%s*(['\"])jabber:client%1.*>"; }; });
For the record, this isn't a compliance issue IMHO. The RFC does not say we MUST NOT support 5223 :) In fact we support lots of things that are not in the RFC. Also note that it is disabled by default, very few installations have it enabled. The ones that do probably have a reason for it. I'm +1 to moving it into a module though, if it cuts down on code elsewhere. I suspect though that it won't really.
ChangesType-DefectType-EnhancementIt doesn't seem to cut code elsewhere AFAICS (other than moving that net-provider out of mod_c2s)
There are deployments that need this (some people argue that 5223 should be standardized, because it's useful). We might move it into a module, but the benefits don't seem worth it for a few lines of code. Closing for now.
Changes