#468 <stream:stream> "from" attribute missing on some connection errors

Reporter ArcRiley
Owner MattJ
Created
Updated
Stars ★ (1)  
Tags
  • Milestone-0.9
  • Interoperability
  • Status-Fixed
  • Priority-Medium
  • Type-Defect
  1. ArcRiley on

    While working on mod_xmpp I discovered that Prosody does not comply with RFC 6120 in response stream headers. See https://tools.ietf.org/html/rfc6120#page-37 : For response stream headers in both client-to-server and server-to-server communication, the receiving entity MUST include the 'from' attribute and MUST set its value to one of the receiving entity's FQDNs (which MAY be an FQDN other than that specified in the 'to' attribute of the initial stream header, as described under Section 4.9.1.3 and Section 4.9.3.6). When connecting to Prosody 0.9.4: c: <stream:stream xmlns='jabber:client' xmlns:stream='http://etherx.jabber.org/streams' to='nope' version='1.0'> s: <?xml version='1.0'?><stream:stream xmlns:stream='http://etherx.jabber.org/streams' xmlns='jabber:client' version='1.0' id=''><stream:error><host-unknown xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xmlns='urn:ietf:params:xml:ns:xmpp-streams'>This server does not serve nope</text></stream:error></stream:stream> Note that the server's response does not include the required from attribute.

  2. MattJ on

    Hi, thanks for the report! Looks like we can set it to the empty string: https://tools.ietf.org/html/rfc6120#section-4.9.1.3

    Changes
    • owner MattJ
    • tags Milestone-0.9 Interoperability Status-Accepted
  3. MattJ on

    Fixed in b1c84d220c40 for release in 0.9.8 shortly.

    Changes
    • tags Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.