#575 XEP-0191, mod_blocklist: MUST send error reply if user sends presence to blocked contact

Reporter Zash
Owner Zash
Created
Updated
Stars ★ (1)
Tags
  • Compliance
  • Status-Fixed
  • Priority-Low
  • Milestone-0.10
  • Type-Defect
  1. Zash on

    Text just before example 9 says we MUST return an <not-acceptable/> error if a stanza is sent to a blocked contact. Currently presence stanzas are just dropped here. There may be a good reason for this which at least should be documented. Maybe due to server generated presence broadcasts passing by here which might spam the user with errors every time they move.

  2. Zash on

    This text from XEP-0191: If the user attempts to send an outbound stanza to the contact, the user's server MUST NOT route the stanza to the contact but instead MUST return a <not-acceptable/> error containing an application-specific error condition of <blocked/> qualified by the 'urn:xmpp:blocking:errors' namespace

  3. Zash on

    Comment added. I think fixing this requires changes to how mod_presence does broadcasting. Not sure how large tho.

  4. Zash on

    https://hg.prosody.im/0.10/rev/31d8e1a8a014

  5. Zash on

    Changes
    • tag Priority-Low
  6. Zash on

    Changes
    • tags Status-Accepted
  7. Zash on

    Changes
    • tags Milestone-0.10 Status-Started
    • owner Zash
  8. Zash on

    Fixed in https://hg.prosody.im/0.10/rev/0fd63ed1f647

    Changes
    • tags Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.