#682 Send affilition changes to participants even if the jid whos aff. changed is not in the room
Reporter
Daniel Gultsch
Owner
Zash
Created
Updated
Stars
★★ (2)
Tags
Type-Enhancement
Priority-Medium
Status-Accepted
Daniel Gultsch
on
Description of feature:
Issue #445 would allow users to request the entire member list (and I'm including admins and owners) on join. But if one of the affiliation changes while they are in the room they won't notice unless the members whos affiliation was changed happens to be in the room as well.
Sending a notification message to all participants if an affiliation changes would fix this and would allow all participants to keep the member list updated.
This is described in the examples 176, 190, 195 (but should also include other affiliation changes that do not have an example like getting removed from the member list or getting added to the member list)
Together with #445 this can really improve the UX for WhatsApp style group chats. ejabberd already has support for this and so does Conversations.
Hi,
I think there might be some misunderstanding. After re-reading the text one year after opening this issue I understand why this is confusing. I might be wrong and the XEP doesn't even allow for what I'm trying to accomplish.
Anyway. Let's assume a room has four members. Member A, B, C and D. Member A and B are currently offline (not joined). Member C (the owner) changes the affiliation changes the affiliation of Member A. I want the room to inform member C and D of that fact.
I think what you are doing is informing member A.
But as I said. After reading the XEP again I'm not even sure that's allowed.
Daniel Gultsch
on
The examples are really confusing. If we look at 176 the from jid should probably be the room jid... But it is also send to the full jid of the recipient which indicates that crone1 is currently joined...
Zash
on
I think the best thing to do here, especially if this is isn't defined by the XEP, is for you to copy affiliation_notify.lib.lua into a mod_muc_notify_everyone_about_affiliations and change it to do what you want. Perhaps mention it on the XSF standards list as well.
Description of feature: Issue #445 would allow users to request the entire member list (and I'm including admins and owners) on join. But if one of the affiliation changes while they are in the room they won't notice unless the members whos affiliation was changed happens to be in the room as well. Sending a notification message to all participants if an affiliation changes would fix this and would allow all participants to keep the member list updated. This is described in the examples 176, 190, 195 (but should also include other affiliation changes that do not have an example like getting removed from the member list or getting added to the member list) Together with #445 this can really improve the UX for WhatsApp style group chats. ejabberd already has support for this and so does Conversations.
MUC in current trunk, what'll become 0.11 at some point, already supports this: https://hg.prosody.im/trunk/file/tip/plugins/muc/affiliation_notify.lib.lua It would be great if you could test this and report back.
ChangesHi, I think there might be some misunderstanding. After re-reading the text one year after opening this issue I understand why this is confusing. I might be wrong and the XEP doesn't even allow for what I'm trying to accomplish. Anyway. Let's assume a room has four members. Member A, B, C and D. Member A and B are currently offline (not joined). Member C (the owner) changes the affiliation changes the affiliation of Member A. I want the room to inform member C and D of that fact. I think what you are doing is informing member A. But as I said. After reading the XEP again I'm not even sure that's allowed.
The examples are really confusing. If we look at 176 the from jid should probably be the room jid... But it is also send to the full jid of the recipient which indicates that crone1 is currently joined...
I think the best thing to do here, especially if this is isn't defined by the XEP, is for you to copy affiliation_notify.lib.lua into a mod_muc_notify_everyone_about_affiliations and change it to do what you want. Perhaps mention it on the XSF standards list as well.
ChangesMilestone-0.11