When a message without a body is received mod_mam always ignores the forced storage hint, even if <store xmlns='urn:xmpp:hints'/> is present.
This can cause issue with OMEMO, which sends message elements without a body.
This can be addressed by checking for forced storage in this method:
https://hg.prosody.im/prosody-modules/file/tip/mod_mam/mod_mam.lua#l241
I'll work on a patch.
Zash
on
I believe the omission is because <store/> is a recent addition to the XEP, only added a year ago!
However, since currently all messages with type='chat' are stored, this shouldn't be a problem for OMEMO, but your archive will be full of chat states. Maybe this can be reverted in favor of <store/> now...
Changes
owner Zash
tags Status-Accepted
Chris Ballinger
on
Ah that makes sense, I guess I can leave it as-is for now and it should work because it's type="chat". Thanks for the quick response!
When a message without a body is received mod_mam always ignores the forced storage hint, even if <store xmlns='urn:xmpp:hints'/> is present. This can cause issue with OMEMO, which sends message elements without a body. This can be addressed by checking for forced storage in this method: https://hg.prosody.im/prosody-modules/file/tip/mod_mam/mod_mam.lua#l241 I'll work on a patch.
I believe the omission is because <store/> is a recent addition to the XEP, only added a year ago! However, since currently all messages with type='chat' are stored, this shouldn't be a problem for OMEMO, but your archive will be full of chat states. Maybe this can be reverted in favor of <store/> now...
ChangesAh that makes sense, I guess I can leave it as-is for now and it should work because it's type="chat". Thanks for the quick response!
Setting a milestone so I don't forget this.
ChangesI believe this should now be fixed in https://hg.prosody.im/0.10/rev/04b09fd144eb
ChangesBtw, the hint is not "forced". It's just a hint. The server is free to ignore it.