#776 Inequal handling of c2s and s2s stanzas in debug logs

Reporter Ge0rG
Owner Zash
Stars ★ (1)
  • Priority-Medium
  • Status-Fixed
  • Milestone-0.11
  • Type-Enhancement
  1. Ge0rG on

    Prosody's debug logging is pretty verbose, but it is missing a log line for stanzas sent over c2s connections. There is one line per received stanza, via c2s and s2s: Nov 04 18:52:38 c2s489acf0 debug Received[c2s]: <presence id='jWU0t-414' to='conversations@conference.siacs.eu/Ge0rG'> Nov 04 18:52:38 s2sin25fca70 debug Received[s2sin]: <presence id='jWU0t-414' to='georg@yax.im/yaxim' from='conversations@conference.siacs.eu/Ge0rG'> There are three (or four, if you count the routing debug) stanzas for sending over s2s: Nov 04 18:52:38 stanzarouter debug Routing to remote... Nov 04 18:52:38 s2sout206ca60 debug going to send stanza to conference.siacs.eu from yax.im Nov 04 18:52:38 s2sout206ca60 debug sending: <presence id='jWU0t-414' to='conversations@conference.siacs.eu/Ge0rG' from='georg@yax.im/yaxim'> Nov 04 18:52:38 s2sout206ca60 debug stanza sent over s2sout And there is not a single line logging the stanza that is sent to a client. Please make the s2s-out logging a bit less verbose, and add a c2s-out line for that.

  2. MattJ on

    Without looking at the code, possibly we can remove "stanza sent over s2sout", and add an equivalent "sending:" line for c2s that s2s has.

    • tags Status-Accepted
  3. Zash on

    I started working on this in a branch.

    • owner Zash
    • tags Status-Started
  4. Zash on

    Done in https://hg.prosody.im/trunk/rev/1b272b51ae0f .. f3adcc3fce8c

    • tags Status-Fixed Milestone-0.11
  5. MattJ on

    Backported to 0.10 also as https://hg.prosody.im/0.10/rev/af97ecd00734 .. 22e5f11c778a

New comment

Not published. Used for spam prevention and optional update notifications.