#935 MAM:0 fin message shouldn’t be offline’d to other clients
Reporter
Link Mauve
Owner
Nobody
Created
Updated
Stars
★ (1)
Tags
Status-New
Type-Defect
Priority-Medium
Link Mauve
on
What steps will reproduce the problem?
1. Start Gajim.
2. Stop Gajim before it has received all of the :0 MAM messages.
3. Open another client.
What is the expected output? What do you see instead?
I shouldn’t get this stanza, instead I receive it: <message xmlns="jabber:client" to="linkmauve@linkmauve.fr/Gajim"><fin xmlns="urn:xmpp:mam:0" complete="true" queryid="53951658-68be-4c2a-98bd-5b394a62ae88"><set xmlns="http://jabber.org/protocol/rsm" /></fin><delay xmlns="urn:xmpp:delay" from="linkmauve.fr" stamp="2017-06-14T00:16:45Z" /><delay xmlns="urn:xmpp:delay" from="linkmauve.fr" stamp="2017-06-14T00:21:48Z" /></message>
Additionally, there shouldn’t be two delay elements.
What version of the product are you using? On what operating system?
Prosody hg:3e443d6791e6 on Lua 5.1, on ArchLinuxARM.
Please provide any additional information below.
This is running mod_mam from prosody-modules, version 9b43b7fc3558.
Zash
on
Are there any other non-core modules enabled, like perhaps mod_smacks_offline?
Link Mauve
on
I indeed have this module enabled.
MattJ
on
I'm not really sure of a sensible way to fix this. The current mod_smacks uses filters to intercept messages sent to sessions. Apart from adding specialized logic to identify this particular stanza, there is no way I can see to indicate "this stanza should not be sent to another resource".
I guess this is why Ge0rg was arguing for using type="headline" for MAM stanzas.
What steps will reproduce the problem? 1. Start Gajim. 2. Stop Gajim before it has received all of the :0 MAM messages. 3. Open another client. What is the expected output? What do you see instead? I shouldn’t get this stanza, instead I receive it: <message xmlns="jabber:client" to="linkmauve@linkmauve.fr/Gajim"><fin xmlns="urn:xmpp:mam:0" complete="true" queryid="53951658-68be-4c2a-98bd-5b394a62ae88"><set xmlns="http://jabber.org/protocol/rsm" /></fin><delay xmlns="urn:xmpp:delay" from="linkmauve.fr" stamp="2017-06-14T00:16:45Z" /><delay xmlns="urn:xmpp:delay" from="linkmauve.fr" stamp="2017-06-14T00:21:48Z" /></message> Additionally, there shouldn’t be two delay elements. What version of the product are you using? On what operating system? Prosody hg:3e443d6791e6 on Lua 5.1, on ArchLinuxARM. Please provide any additional information below. This is running mod_mam from prosody-modules, version 9b43b7fc3558.
Are there any other non-core modules enabled, like perhaps mod_smacks_offline?
I indeed have this module enabled.
I'm not really sure of a sensible way to fix this. The current mod_smacks uses filters to intercept messages sent to sessions. Apart from adding specialized logic to identify this particular stanza, there is no way I can see to indicate "this stanza should not be sent to another resource". I guess this is why Ge0rg was arguing for using type="headline" for MAM stanzas.