#956 Carbons: forwarded 'sent' message lacks 'to' attribute

Reporter Ge0rG
Owner Zash
Stars ★★ (2)
  • Priority-Medium
  • Status-Fixed
  • Milestone-0.10
  • Type-Defect
  1. Ge0rG on

    Running prosody 0.10 with mod_carbons, if you send a message to your own bare JID, it will be carbon-copied to your other client. The carbon copy is lacking the 'to' element (it is stripped from the original message by prosody): Original message as sent by /poezio: <message to="georg@domain.im" id="X" type="chat"> <body>test</body> </message> Carbon-copy as received by /yaxim: <message to="georg@domain.im/yaxim" from="georg@domain.im" type="chat"> <sent xmlns="urn:xmpp:carbons:2"> <forwarded xmlns="urn:xmpp:forward:0"> <message id="X" from="georg@domain.im/poezio" type="chat"> <body>test</body> </message> </forwarded> </sent> </message> According to https://xmpp.org/rfcs/rfc6120.html#stanzas-attributes-to-c2s this implies that the carbon-copied message was intended to be processed by the server (this is different from being addressed to your bare JID, thanks RFC6121). Either way, it is a bad idea to have carbon-copied messages lack either 'from' or 'to'.

  2. Zash on

    • owner Zash
    • tags Status-Accepted Milestone-0.10
  3. MattJ on

    Zash: release blocker? Probably just set the 'to' to the bare JID if nil, for now?

  4. Zash on

    Fixed in https://hg.prosody.im/0.10/rev/b41947a0fc0c

    • tags Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.