#974 mod_smacks causes two TCP segments to be sent
Reporter
Ge0rG
Owner
Nobody
Created
Updated
Stars
★★ (2)
Tags
Status-Fixed
Priority-Medium
Type-Defect
Milestone-0.12
Ge0rG
on
Whenever mod_smacks issues an <r/> over a session, it will do session.send right after the stanza that caused the transmission (every stanza by default) has been sent.
That means, the transmission goes like that:
```
--> stanza(s)
<-- ack
--> <r/> (Nagle's algorithm makes the TCP stack wait for the ack until sending out the next incomplete segment)
<-- ack
<-- <a/>
--> ack
```
It would be great if prosody could piggy-back the <r/> on the stanza(s) segment, to reduce the number of round trips and the battery drain on mobile clients. Thanks.
Zash
on
Changes
tags Component-Community
Zash
on
Tagging issue as affecting a community module, not officially supported by the Prosody team.
Changes
tags
Zash
on
mod_smacks shipped with Prosody takes some steps to include the <r/> in the same write() call as the stanza it's requesting ack for
https://hg.prosody.im/trunk/rev/6da703cb4c04
Whenever mod_smacks issues an <r/> over a session, it will do session.send right after the stanza that caused the transmission (every stanza by default) has been sent. That means, the transmission goes like that: ``` --> stanza(s) <-- ack --> <r/> (Nagle's algorithm makes the TCP stack wait for the ack until sending out the next incomplete segment) <-- ack <-- <a/> --> ack ``` It would be great if prosody could piggy-back the <r/> on the stanza(s) segment, to reduce the number of round trips and the battery drain on mobile clients. Thanks.
Tagging issue as affecting a community module, not officially supported by the Prosody team.
Changesmod_smacks shipped with Prosody takes some steps to include the <r/> in the same write() call as the stanza it's requesting ack for https://hg.prosody.im/trunk/rev/6da703cb4c04
ChangesComponent-CommunityMilestone-0.12 Status-Fixed