#1260 util.rfc6724: bad argument #1 to 'ipairs' (table expected, got nil)
Reporter
MattJ
Owner
Nobody
Created
Updated
Stars
★ (1)
Tags
Milestone-0.11
Priority-Medium
Type-Defect
Patch
Status-CantFix
MattJ
on
What steps will reproduce the problem?
Unknown.
What do you see?
Error in DNS response handler: /usr/lib/prosody/util/rfc6724.lua:132: bad argument #1 to 'ipairs' (table expected, got nil)
What version of the product are you using? On what operating system?
Prosody 0.11 nightly build 16 (2018-12-01, 6f97acc4583b)
MattJ
on
Changes
tags Milestone-0.11
Zash
on
Changes
tags Status-NeedInfo
Zash
on
Race perhaps? Or callbacks called more than once? Or #1267 ?
The "expected table" here is session.ip_hosts which does get set to nil after the state machine proceeds to the next SRV record or when the connection is completed.
Waqas
on
We have evidence of ondisconnect being called multiple times, seemingly in different scenarios.
Zash
on
Attempt to fix this in https://hg.prosody.im/timber/rev/fd659bc10727 but without a way to reproduce it is hard to verify that it fixes it.
Further, with this code no longer used in 0.12 and I don't remember any users reporting encountering this, perhaps simply just WontFix?
Changes
tags Patch
Zash
on
util.rfc6724 isn't used in 0.12 and has been deleted in trunk, all bugs with it are fixed!
What steps will reproduce the problem? Unknown. What do you see? Error in DNS response handler: /usr/lib/prosody/util/rfc6724.lua:132: bad argument #1 to 'ipairs' (table expected, got nil) What version of the product are you using? On what operating system? Prosody 0.11 nightly build 16 (2018-12-01, 6f97acc4583b)
Race perhaps? Or callbacks called more than once? Or #1267 ? The "expected table" here is session.ip_hosts which does get set to nil after the state machine proceeds to the next SRV record or when the connection is completed.
We have evidence of ondisconnect being called multiple times, seemingly in different scenarios.
Attempt to fix this in https://hg.prosody.im/timber/rev/fd659bc10727 but without a way to reproduce it is hard to verify that it fixes it. Further, with this code no longer used in 0.12 and I don't remember any users reporting encountering this, perhaps simply just WontFix?
Changesutil.rfc6724 isn't used in 0.12 and has been deleted in trunk, all bugs with it are fixed!
Changes