#1317 mod_smacks: h=nil stacktrace

Reporter ge0rg
Owner Nobody
Created
Updated
Stars ★ (1)
Tags
  • Priority-Medium
  • Status-Fixed
  • Patch
  • Type-Defect
  • Component-Community
  1. ge0rg on

    Found this stacktrace today, prosody 0.10 latest nightly, prosody-modules up-to-date from today: Feb 07 18:26:12 rostermanager debug load_roster: asked for: *censored*@yax.im Feb 07 18:26:12 rostermanager debug load_roster: loading for offline user: *censored*@yax.im Feb 07 18:26:12 socket debug try to close client connection with id: 55694f952230 Feb 07 18:26:12 socket debug closing delayed until writebuffer is empty Feb 07 18:26:12 mod_c2s error Traceback[c2s]: /etc/prosody/modules-enabled/mod_smacks.lua:348: attempt to perform arithmetic on local 'h' (a nil value) stack traceback: /etc/prosody/modules-enabled/mod_smacks.lua:348: in function </etc/prosody/modules-enabled/mod_smacks.lua:332> (tail call): ? /usr/lib/prosody/util/events.lua:78: in function </usr/lib/prosody/util/events.lua:74> (tail call): ? ...-enabled/mod_log_slow_events/mod_log_slow_events.lua:12: in function <...-enabled/mod_log_slow_events/mod_log_slow_events.lua:10> (tail call): ? /usr/lib/prosody/core/stanza_router.lua:152: in function </usr/lib/prosody/core/stanza_router.lua:63> (tail call): ? [C]: in function 'xpcall' /usr/lib/prosody/modules/mod_c2s.lua:141: in function 'cb_handlestanza' ... /usr/lib/prosody/util/xmppstream.lua:271: in function 'feed' /usr/lib/prosody/modules/mod_c2s.lua:265: in function 'data' /usr/lib/prosody/modules/mod_c2s.lua:288: in function 'onincoming' /usr/lib/prosody/net/server_event.lua:608: in function </usr/lib/prosody/net/server_event.lua:557> [C]: in function 'loop' /usr/lib/prosody/net/server_event.lua:751: in function </usr/lib/prosody/net/server_event.lua:750> [C]: in function 'xpcall' /usr/bin/prosody:400: in function 'loop' /usr/bin/prosody:431: in main chunk [C]: ?

  2. ge0rg on

    https://op-co.de/tmp/smacks_fix_1317.diff KTHX

  3. ge0rg on

    Context (2019-02-07): 17:49:21 <Ge0rG>  Zash: https://issues.prosody.im/1317 please? 17:49:30 <Zash>  Ge0rG: I don't do mod_smacks 17:49:38 <Ge0rG>  Zash: nobody does. 17:51:05 <Ge0rG>   if not h then origin:close{ condition = "invalid-xml"; text = "Missing or invalid 'h' attribute"; }; end local handled_stanza_count = h-origin.last_acknowledged_stanza; 17:51:09 <Ge0rG>  how can that even happen? 17:51:25 <Ge0rG>  wait. it doesn't quit there, right? 17:51:39 <Ge0rG>  can I just stuff a return after the close and be done? 17:51:49 <Zash>  I think so, yes 17:52:27 <Ge0rG>  :pray: 17:52:55 <Zash>  Now commit that and submit a patch

  4. Zash on

    https://hg.prosody.im/prosody-modules/rev/1f2381492c9f

    Changes
    • tags Component-Community Patch Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.